Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align images for multiline titles in CS section #608

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ernestofgonzalez
Copy link
Contributor

Fixes gh-416

  1. Set images width and height to be the same. The static/images/content_images/case_studies/deeplabcut.png has different aspect ratio than the rest, which resulted in misalignment with other cards in 2x2 grid.
  2. Set title height to be the double of line height. This guarantees alignment of all images in case of titles with two lines.

A note on point 2: A more interesting approach could be to check the number of lines of the longest title and set the line height of all titles to the line height of that one. I tried this but couldn't make the height of the card to update accordingly.

@netlify
Copy link

netlify bot commented Oct 29, 2022

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit 592b23e
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/635d36ace9a4b50008ec91d5
😎 Deploy Preview https://deploy-preview-608--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor Author

@ernestofgonzalez ernestofgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auto margin bottom was from another experiment I was running. I had forgot to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment of titles in the (translated) Case Studies section
1 participant